Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty workflowDidChange from Xcode project templates #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove empty workflowDidChange from Xcode project templates #314

wants to merge 1 commit into from

Conversation

blakemcanally
Copy link
Contributor

@blakemcanally blakemcanally commented Nov 14, 2024 •
edited
Loading

Remove the empty workflowDidChange(from previousWorkflow:state:) method from Xcode project templates and tests.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@blakemcanally blakemcanally marked this pull request as ready for review November 14, 2024 19:24
@blakemcanally blakemcanally requested a review from a team as a code owner November 14, 2024 19:24
jamieQ
jamieQ approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jamieQ jamieQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're in here, would you mind seeing if we can remove this one as well? seems like it is redundant since we have a blanket default implementation (though i haven't personally tried compiling it).

@blakemcanally blakemcanally force-pushed the mcanally/omit_empty_workflowDidChange branch from 42c57c0 to c908fda Compare November 15, 2024 02:33
@blakemcanally
Copy link
Contributor Author

while you're in here, would you mind seeing if we can remove this one as well? seems like it is redundant since we have a blanket default implementation (though i haven't personally tried compiling it).

updated! lets see how CI likes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamieQ jamieQ jamieQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakemcanally @jamieQ